Remove dependency on bos. #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbuenzli
force-pushed
the
remove-bos-dep
branch
from
c84ce5b
to
82086fd
Compare
|
It looks like the replacement code should use |
aantron
reviewed
Feb 15, 2019
dbuenzli
force-pushed
the
remove-bos-dep
branch
2 times, most recently
from
301672d
to
763b2db
Compare
dbuenzli
force-pushed
the
remove-bos-dep
branch
from
763b2db
to
22dff55
Compare
A bit odd there were quite a few other |
|
Agreed, haven't looked into what's happening there. Thanks! |
This was referenced Mar 8, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tools like odoc at the roots of the eco-system should be lean on deps. This removes one of them.
In this case it seems only
Bos.File.readwas being used. I added something that is functionally equivalent.