Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator: Add missing space before class name #339

Merged
merged 3 commits into from
Mar 20, 2019
Merged

generator: Add missing space before class name #339

merged 3 commits into from
Mar 20, 2019

Conversation

kevinji
Copy link
Contributor

@kevinji kevinji commented Mar 19, 2019

Fixes #338. I tested this locally by generating the docs for Ppxlib_traverse_builtins and it seemed to have inserted the space.

@kevinji kevinji changed the title generator: Fix missing space before class name generator: Add missing space before class name Mar 19, 2019
@aantron
Copy link
Contributor

aantron commented Mar 19, 2019

Thanks!

Would you mind adding two tests where this new space is needed? It should be as easy as adding two more declarations to class.mli:

class type empty =
object
end
class type mutually =
object
end
and recursive =
object
end
class mutually' : mutually
and recursive' : recursive
class type virtual empty_virtual =
object
end
class virtual empty_virtual' : empty

something like class ['a] polymorphic (* ... *) and class type ['a] polymorphic (* ... *), then running make test, and following the instructions again to replace the output with the new one.

@kevinji
Copy link
Contributor Author

kevinji commented Mar 19, 2019

Done, thanks for the guidance.

@aantron aantron merged commit 3897c73 into ocaml:master Mar 20, 2019
@aantron
Copy link
Contributor

aantron commented Mar 20, 2019

Thanks again.

aantron pushed a commit that referenced this pull request Mar 20, 2019
@kevinji kevinji deleted the fix-missing-space-between-polymorphic-variable-and-class-name branch March 20, 2019 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants