Check that tidy supports the mute option #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greedy
force-pushed
the
sanity-check-tidy
branch
from
c04debb
to
5c73df6
Compare
macOS comes with tidy but it is an old version that does not support the `--mute` option. This leads to spurious test failures on macOS. This adds a check to is_present_in_path that requires the available version of tidy support the mute configuration option before it will be used.
greedy
force-pushed
the
sanity-check-tidy
branch
from
5c73df6
to
24cdb61
Compare
|
Thanks. I think we'd eventually prefer a version check, but this works. |
|
@aantron a version check was the first thing I had in mind but the version string for the version on macOS El Captian (yes, I know, it's quite old) reads HTML Tidy for Mac OS X released on 31 October 2006 - Apple Inc. build 15.17 where 5.6.0 built here says HTML Tidy for Apple macOS version 5.6.0 so it's not too straightforward to compare the version strings. |
|
Argh, yes, fair enough. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS comes with tidy but it is an old version that does not support the
--muteoption. This leads to spurious test failures on macOS.This adds a check to is_present_in_path that requires the available version of tidy support the mute configuration option before it will be used.