Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span things #360

Merged
merged 5 commits into from
Jun 11, 2019
Merged

Span things #360

merged 5 commits into from
Jun 11, 2019

Conversation

trefis
Copy link
Contributor

@trefis trefis commented May 28, 2019

#359 reloaded:

  • it's closer to @dbuenzli's initial markup
  • I also <span> type constructors and their parameters together
  • the implementation is much cleaner.
  • I've updated the testsuite!

The final result for the extreme example I was using doesn't look quite as nice:
markup

But it's reasonable, and Daniel seems to thing the markup proposed here will be better in general, which I tend to agree with.
I'm considering including some special handling for extreme cases like the one in the screenshot, but that will wait until a later date.

I think that unlike #359 this is in a reasonable state and is ready for review.

@trefis
Copy link
Contributor Author

trefis commented May 29, 2019

The failure is only on 4.08 and because one of our dependencies doesn't build.
But since we're using beta1 in travis (which is known to be broken), I don't think it's worth investigating. (4.08 is going to be release in the coming days, potentially even today, let's just update travis at that point).

@aantron aantron merged commit 8381952 into master Jun 11, 2019
@aantron
Copy link
Contributor

aantron commented Jun 11, 2019

Thanks!

And thanks also for including the test diff with each commit.

@aantron aantron deleted the span-things branch July 25, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants