Reduce memory usage #361
Merged
Reduce memory usage #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the first two commits are worth having. The third one probably just makes things worse for people other than us -- so we're happy to just keep that on our internal branch until the rewrite is done. |
trefis
force-pushed
the
reduce-memory-usage
branch
from
943a7c3
to
c007f13
Compare
|
I removed the last commit. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some files at janestreet where odoc was using over 40G of memory, this series of patch brings that back down to roughly 10G.
On these files odoc is about 5x slower though.
I expect the rewrite that @jonludlam is currently working on to improve the (resulting as well as preexisting) slowness issues.
In the meantime, these patches are necessary because odoc gets reliably OOM killed when ran from a build system.