Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta generator #378

Merged
merged 2 commits into from
Sep 1, 2019
Merged

Add meta generator #378

merged 2 commits into from
Sep 1, 2019

Conversation

dbuenzli
Copy link
Contributor

@dbuenzli dbuenzli commented Sep 1, 2019

Bring back the versioned meta generator tag (closes #324).

I made the test promotion as a separate commit. Btw. is there a way to promote things via a single diff. I had to run the tests, see one failing, promote, start over, etc. I'm sure I'm missing something.

Also I promoted a few things that seem unrelated to the change but is related to @trefis' spanning of sigs I think.

@dbuenzli
Copy link
Contributor Author

dbuenzli commented Sep 1, 2019

The 4.02.3 failures are unrelated, apparently dune fails to compile.

@aantron aantron merged commit 1843f89 into ocaml:master Sep 1, 2019
@aantron
Copy link
Contributor

aantron commented Sep 1, 2019

Thanks.

IIRC, there is some command you could manually write to promote in one go, but there is no direct "support" for it at the moment.

@dbuenzli
Copy link
Contributor Author

dbuenzli commented Sep 1, 2019

Thanks.

IIRC, there is some command you could manually write to promote in one go,

Eventually got around with:

for i in {1..XXX}; do cp `cat _build/default/test/html/_scratch/actual` `cat _build/default/test/html/_scratch/expected` && make test; done

But it's still very slow...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readd versioned meta generator tag
2 participants