Extended open #393
Merged
Extended open #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Ludlam <jon@recoil.org>
Signed-off-by: Jon Ludlam <jon@recoil.org>
We do this by introducing an artificial module at the point the `open` occurs. For example: ```ocaml open (Foo : module type of Foo with module A := Foo.A) ``` becomes effectively: ```ocaml (**/**) module Open__<line>_<col> : module type of Foo with module A := Foo.A (**/**) ``` and we 'open' this by putting all of the identifiers into the environment. All of these `Ident.t` values are associated with 'Internal' names that are always hidden, and hence the resolution step ends up resolving them to the non-hidden identifiers. It is an error to try and turn the 'Internal' identifiers back into strings in the HTML generator to ensure they don't leak out into the documentation. Signed-off-by: Jon Ludlam <jon@recoil.org>
Until we can properly abstract types that refer to hidden items (ie, until the model rewrite lands), we'll allow these internal names to be exposed (prefixed with '$' to point them out). Signed-off-by: Jon Ludlam <jon@recoil.org>
Signed-off-by: Jon Ludlam <jon@recoil.org>
|
Looks like I've added a couple of binary files by mistake. I'll remove them when I'm back in front of my computer. |
Signed-off-by: Jon Ludlam <jon@recoil.org>
Signed-off-by: Jon Ludlam <jon@recoil.org>
Signed-off-by: Jon Ludlam <jon@recoil.org>
avsm
approved these changes
Nov 4, 2019
|
Sorry for the delay, I'll try to review this tomorrow. |
trefis
requested changes
Nov 5, 2019
Signed-off-by: Jon Ludlam <jon@recoil.org>
Most `open` statements don't create anything new, so in the majority of cases we can skip a chunk of work. Optimization pointed out by @trefis. Signed-off-by: Jon Ludlam <jon@recoil.org>
jonludlam
force-pushed
the
extended-open
branch
from
9a015f4
to
4d9bb39
Compare
trefis
reviewed
Nov 7, 2019
- Don't use to_string_unsafe (yet) - Document that to_string doesn't currently raise exceptions - Extend test to ensure standard use of open isn't affected Signed-off-by: Jon Ludlam <jon@recoil.org>
trefis
approved these changes
Nov 11, 2019
jonludlam
added a commit
to jonludlam/opam-repository
that referenced
this pull request
Feb 7, 2020
CHANGES: Additions - Add option to turn warnings into errors (ocaml/odoc#398, Jules Aguillon) Bugs fixed - Emit quote before identifier in alias type expr (Fixes ocaml/odoc#391, Anton Bachin) - Handle generalized open statements introduced in 4.08 (ocaml/odoc#393, Jon Ludlam) - Refactor error reporting to avoid exiting the program in library code (ocaml/odoc#400, Jules Aguillon) - Build on OCaml 4.10 (ocaml/odoc#408, Jon Ludlam)
mgree
pushed a commit
to mgree/opam-repository
that referenced
this pull request
Feb 19, 2020
CHANGES: Additions - Add option to turn warnings into errors (ocaml/odoc#398, Jules Aguillon) Bugs fixed - Emit quote before identifier in alias type expr (Fixes ocaml/odoc#391, Anton Bachin) - Handle generalized open statements introduced in 4.08 (ocaml/odoc#393, Jon Ludlam) - Refactor error reporting to avoid exiting the program in library code (ocaml/odoc#400, Jules Aguillon) - Build on OCaml 4.10 (ocaml/odoc#408, Jon Ludlam)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle generalized open statements in cmt files.
For review, since I've not implemented the signature side of this yet. Now complete and ready to review.