-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for TOC generation #248
Comments
This might be helpful: remark toc tests. |
@shonfeder, I'm thinking of adding support for different types of tests by having different labels at the end of the lines separating the test cases. What do you think of this approach?
|
@sonologico sorry for the delay! Would your approach mean altering the text of the current If not, I wonder if could just different file names for different kinds of tests? More generally, I'm wondering if we shouldn't split additional tests into two groups:
I don't have a hard opinion here, except that I find the current testing scheme a bit cumbersome to work with, and only justified by the fact that we are presumably working from the original spec text, which is itself left untouched. |
I was planning on adding more another test files. We already have more besides |
Ok! I'm happy for you to proceed however you see fit, tho also happy to offer opinions where useful :) If you do end up deciding the current testing approach is sufficient and preferable, and worth extending, I wouldn't begrudge the effort. I in my own projects, I've preferred alcotest over ounit, and qcheck (sometimes on top of alcotest) over all.
It would be convenient for cases where we want to actually see the generated HTML, but aren't testing to a pre-given spec. |
Played with the idea here: https://github.com/ocaml/omd/blob/sonologico/toc-ppx_expect/src/omd.ml#L29. I think we'll end up needing something like |
Followup to #240
As per #240 (comment)
The text was updated successfully, but these errors were encountered: