[new release] ppx_deriving 6.0.2 #25918
Conversation
|
Let's hope this one works! I opened a draft this time to test out the revdeps builds and added upper bounds to |
|
There's a lot of request time out in the CI. Outside of those I couldn't spot any errors related to |
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
mseri
force-pushed
the
release-ppx_deriving-6.0.2
branch
from
ca18d5e
to
bfc383b
Compare
|
I fixed the merge conflict. I'll let the CI re-run, hopefully we will see less timeouts. I think it's fine to merge |
|
Awesome, thanks! I'll go through with the actual release and undraft! |
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
|
I think this release or one of its dependencies has dropped a dependency on result. I'll send a PR to fix all the broken stuff before merging, sorry for the extra delay this will add |
|
Bounds added in #25951 I think this are safe to add, since they were using result in their code but taking it as transitive dependence from ppx_deriving |
|
Wouldn't the fix be to add the result dependency instead? That way they could still build with ppx_deriving. No worries for the delay, I forgot to come back and check if they were new failures so that's partly on me. |
No because they don't link it explicitly, they were taking it in as transitive dependency |
|
Ah yes you're right! My bad! |
|
Looks good now. The timeouts are a known issue that is being investigated and does not depend on this |
No description provided.