[new release] dune (1.9.2)

[rgrinberg]

Fast, portable and opinionated build system

• Project page: https://github.com/ocaml/dune

CHANGES:

• Put back library variants in development mode. We discovered a
  serious unexpected issue and we might need to adjust the design of
  this feature before we are ready to commit to a final version. Users
  will need to write (using library_variants 0.1) in their
  dune-project file if they want to use it before the design is
  finalized. (Put back library variants in development mode dune#2116, @diml)

• Forbid to attach a variant to a library that implements a virtual
  library outside the current project (Add check for invalid variant implementations dune#2104, @rgrinberg)

• Fix a bug where dune install would install man pages to incorrect
  paths when compared to opam-installer. For example dune now
  installs (foo.1 as man1/foo.1) correctly and previously that was
  installed to man1/man1/foo.1. (Make dune install install man pages in the same place as opam-installer. dune#2105, @aalekseyev)

• Do not fail when a findlib directory doesn't exist (Do not fail when a findlib directory doesn't exist dune#2101, fix Sys_error during "opam install dune" from within a "dune exec" dune#2099, @diml)

• [coq] Rename (coqlib ...) to (coq.theory ...), support for
  coqlib will be dropped in the 1.0 version of the Coq language
  ([coq] Rename (coqlib ...) to (coq.theory ...) dune#2055, @ejgallego)

• Fix crash when calculating library dependency closure (Remove all the shady Option.value_exn in lib.ml dune#2090, fixes Fatal failure while invoking alias dune#2085,
  @rgrinberg)

[kit-ty-kate]

@avsm I (especially) cannot check this PR properly without mirage-ci. Would it be possible to revert to version of cohttp previously installed on the server or something like that, to have it working again?

[camelus]

☀️ All lint checks passed a1b22c2

• These packages passed lint tests: dune.1.9.2

---

☀️ Installability check (11166 → 11167)

• new installable packages (1): dune.1.9.2

[hannesm]

thanks @rgrinberg - is the issue we had with mirage-xen in respect to ocaml/dune#2041 fixed in 1.9.2?

[rgrinberg]

@hannesm I don't think so. I will try and prepare something for 1.9.3

[kit-ty-kate]

Can someone add the appropriate constraint if that's the case?

[mseri]

Should we close this and move on directly with 1.9.3?

[rgrinberg]

What is the reasoning for skipping a release?

[mseri]

There is a known issue, and the fixed release is already ready

[mseri]

We could even release 1.9.3 as 1.9.2, I have nothing against that but I don’t know if you are happy about retagging it.

[rgrinberg]

There is a known issue, and the fixed release is already ready

The known issue also exists in 1.9.1

I'm not happy about re-tagging it because it introduces problems for other users (those who package dune for other package managers) and I don't see the need.

To be honest, I'm not sure if there's anything relevant to discuss here with the maintainers of opam-repository. The release cycle of dune is already agreed upon within the dune team, the goal is to make sure that a release does introduce problems for the rest of the packages in the opam-repository. I think we've already established that.

[mseri]

Fine with me, I was asking for opinions, there are packages that prefer to jump the release in case of known issues

[avsm]

I would like to test revdeps on this before merging -- I'm still trying to diagnose where the CI is failing (its sadly not as simple as reverting it) but am making progress on finding where the notification is being gobbled.

[kit-ty-kate]

I don't think this one should be merge since 1.9.3 has been merged already, or at least without the proper constraints on mirage-xen

[rgrinberg]

If this PR isn't merged then it will create a discrepancy between opam and other package managers that do not have a problem with packaging dune 1.9.2. I'm not sure it's such a bad thing, but it is a bit weird that opam only contains a subset of the dune versions.

[avsm]

There's no objection to merging 1.9.2; just that the mirage-xen conflict also needed to be extended to include this new version or else breakage would ensue for users. We should indeed have all released versions of dune in opam-repository.

I've done the mirage-xen fix in #14125, and then this PR can be merged after that goes in