[new release] opam-monorepo (0.2.1) #17965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: ### Fixed - Fix `--recurse-opam` option for the monorepo lock phase: correctly perform special directory filtering, add an error message when two versions of the same package opam file exist in the source tree, perform package name filtering before checking for uniqueness (tarides/opam-monorepo#151, @TheLortex)
|
I also updated |
|
Commit: 3816dfe A pull request by opam-seasoned @NathanReb. ☀️ All lint checks passed 3816dfe
☀️ Installability check (+1)
|
kit-ty-kate
reviewed
Jan 13, 2021
|
I'll file an issue on opam-monorepo so we can improve the situation in the future but to clarify, we should make it so it always depends on All these dependencies would be in a separate virtual opam package. Does that sound right to you? |
|
yes that sounds perfect! Thanks a lot! |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assemble and manage fully vendored Dune repositories
CHANGES:
Fixed
--recurse-opamoption for the monorepo lock phase: correctly perform special directoryfiltering, add an error message when two versions of the same package opam file exist in the
source tree, perform package name filtering before checking for uniqueness (Fix opam recursion when performing the lock step tarides/opam-monorepo#151, @TheLortex)