Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] re (1.10.0) #19331

Closed
wants to merge 1 commit into from
Closed

Conversation

rgrinberg
Copy link
Member

RE is a regular expression library for OCaml

CHANGES:

CHANGES:

* Add the `[:alpha:]` character class in `Re.Perl` (ocaml/ocaml-re#169)
* Double asterisk (`**`) in `Re.Glob` (ocaml/ocaml-re#172)
  Like `*` but also match `/` characters when `pathname` is set.
* Double asterisk should match 0 or more directories unless in trailing
  position. (ocaml/ocaml-re#192, fixes ocaml/ocaml-re#185)
@mseri
Copy link
Member

mseri commented Sep 2, 2021

The failures seem to be independent

@kit-ty-kate
Copy link
Member

The failures seem to be independent

These ones don't seem to be:

# File "src/tyre.ml", line 332, characters 19-29:
# 332 |     Seq.map aux @@ Re.all_seq ~pos ~len re original
#                          ^^^^^^^^^^
# Error: Unbound value Re.all_seq
# Hint: Did you mean all_gen?

I double checked and it worked with the previous version of re (1.9.0). However I can't find the commit that removed it or any mention of it in the changelog, which i find very weird. @rgrinberg was this meant to happen?

@rgrinberg
Copy link
Member Author

Good catch. This was indeed an accidental regression. I released 1.10.1 with the fixe.

@rgrinberg rgrinberg closed this Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glob: Double asterisk is not matching zero directories
3 participants