Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] goblint-cil (2.0.2) #24400

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

sim642
Copy link
Contributor

@sim642 sim642 commented Sep 11, 2023

A front-end for the C programming language that facilitates program analysis and transformation

CHANGES:

CHANGES:

* Rename `Rmtmps` to `RmUnused` (goblint/cil#135).
* Add option to add return statement to `noreturn` functions (goblint/cil#129).
* Fix empty `if`s being removed (goblint/cil#140).
* Fix `_Float128` support (goblint/cil#118, goblint/cil#119).
* Fix C11 `_Alignas` computation (goblint/cil#130).
* Fix renaming and merging of `inline` functions based on C standard (goblint/cil#120, goblint/cil#124).
* Fix `Pretty` not resetting all global state between calls (goblint/cil#133, goblint/cil#134).
* Fix `fundec` location in merger (goblint/cil#139).
* Fix `cilly` patcher (goblint/cil#128).
* Disable basename by default in parser.
@sim642
Copy link
Contributor Author

sim642 commented Sep 11, 2023

CI failures:

  1. goblint revdeps: failed: Unbound module Rmtmps.

    I'll add upper bounds.

    EDIT: Adding the upper bounds caused revdeps builds which now fail on fedora-38 and opensuse-tumbleweed:

    # (cd _build/default && ./make.sh test)
    # ./scripts/update_suite.rb:44:in `<main>': undefined method `exists?' for File:Class (NoMethodError)
    # 
    # if File.exists?(goblintbyte) then
    #        ^^^^^^^^
    # Did you mean?  exist?
    

    Not sure if there's anything to do about Ruby version being incompatible with test scripts of old releases of goblint.

    EDIT2: There's a patch in [new release] lintcstubs (2 packages) (0.4.7) #24406 for it.

  2. oraclelinux-9: # Can't locate FindBin.pm in @INC (you may need to install the FindBin module).

    Ruby seems somehow broken on Oraclelinux 9. There was a fix to conf-ruby previously (conf-ruby: add rubygems depext on oraclelinux #22003), but Oraclelinux 9 is new since then. The oraclelinux-8 CI jobs work fine.

  3. freebsd:

    #=== ERROR while compiling conf-gcc.1.0 =======================================#
    "gcc": command not found.
    

    Depexts don't seem to install gcc on FreeBSD.

  4. fedora-38-ocaml-5.0: Could not update repository "default": /usr/bin/opam: "rmdir" failed on /home/opam/.opam/repo/default.new: No such file or directory.

    Seems to be some CI problem.

@mseri
Copy link
Member

mseri commented Sep 12, 2023

Fixes for the failing tests have been presented here: https://github.com/ocaml/opam-repository/pull/24406/files
Perhaps you want to include them in 2.0.2?

@sim642
Copy link
Contributor Author

sim642 commented Sep 12, 2023

The patches are for goblint, not goblint-cil.

@mseri
Copy link
Member

mseri commented Sep 12, 2023

A you are right. I guess we have to live with the oraclelinux failures then.

@avsm avsm merged commit 609cd39 into ocaml:master Sep 12, 2023
@avsm
Copy link
Member

avsm commented Sep 12, 2023

Thanks! You may want to announce this on https://discuss.ocaml.org, where we have a Community category and an announce tag for this purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants