Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ott: fix for building on Windows (without symlink) #24942

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

MSoegtropIMC
Copy link
Contributor

This PR merges the Windows fix from the Opam MinGW repo:

https://github.com/ocaml-opam/opam-repository-mingw/tree/sunset/packages/ott/ott.0.32

and adds a correspnding fix for ott.0.33.

For older versions of ott the MinGW repo has no patches - not sure if these work or not, I didn't test it.

The change does not influence builds on other systems, so I did not change the version numbers.

@MSoegtropIMC
Copy link
Contributor Author

@dra27 : after this is merged, should I do a PR to the MinGW sunset repo and remove ott from there? Afair we said that the sunset repo should only be used on top of the main repo and that we want to move everything gradually to the main repo. Such updates look like a good opportunity to do this. Maybe we should leave a readme file in the ott folder of the sunset repo.

@MSoegtropIMC
Copy link
Contributor Author

@dra27 : can I please have a review of this asap - otherwise I have to keep this as local patch in Coq Platform (release is in progress).

@mseri
Copy link
Member

mseri commented Dec 21, 2023

Since this is only affecting windows and is used in production by coq, I am going to take over the decision and merge it in the meantime. We can always revisit if needed

@mseri mseri merged commit b9457ef into ocaml:master Dec 21, 2023
2 checks passed
@MSoegtropIMC
Copy link
Contributor Author

@mseri : thanks, I appreciate it:

@dra27 : the question remains, if I should do a PR to remove this project entirely from the MinGW sunset repo - IMHO the best strategy is to make project by project work on Windows with the main opam repo and delete them from the MinGW repo - until it is empty. This of course requires that everybody uses the MinGW repo as overlay to the main repo - nut sure if this is the communicated policy.

As indicated above, I think we should replace the ott project in the MinGW repo with a Readme file stating that it now lives in the main repo + a link with an explanation of the repo overlaying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants