lru-cache and css: fix tarball urls (and checksum for lru_cache 0.4.0) #25410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseri
reviewed
Mar 5, 2024
| @@ -32,9 +32,9 @@ build: [ | |||
| dev-repo: "git+https://framagit.org/zoggy/ocaml-lru-cache.git" | |||
| url { | |||
| src: | |||
| "https://framagit.org/zoggy/ocaml-lru-cache/-/archive/0.4.0/ocaml-lru-cache-0.4.0.tar.bz2" | |||
| ""https://zoggy.frama.io/ocaml-lru-cache/releases/ocaml-lru-cache-0.4.0.tar.gz | |||
There was a problem hiding this comment.
Suggested change
| ""https://zoggy.frama.io/ocaml-lru-cache/releases/ocaml-lru-cache-0.4.0.tar.gz | |
| "https://zoggy.frama.io/ocaml-lru-cache/releases/ocaml-lru-cache-0.4.0.tar.gz" |
There was a problem hiding this comment.
Can we stick to the tar bz2 and avoid changing the checksum for this one?
There was a problem hiding this comment.
I have manually compared the two tarballs, so I know that the content is the same. It is mostly to avoid breaking other people code (for example, often changing checksums breaks nix users, not sure if this is the case here since you also change file name)
There was a problem hiding this comment.
sure we can keep the tar.bz2. Do you have the original one somewhere ?
There was a problem hiding this comment.
Co-authored-by: Marcello Seri <mseri@users.noreply.github.com>
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix after discussions in #25344 and #25361 .