Disable conf-zstd.0.1 #25441
Merged
Disable conf-zstd.0.1 #25441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the maintenance of this package by only having one version to contend with. The original addition of conf-zstd.1.3.8 was somewhat flawed - opam does not support depext version contraints, so packages trying to encode these should use a different name from the conf package, to ease the maintenance of the depexts list. Of the major distributions: - Ubuntu has had 1.3.8+ since Disco (19.04) - Fedora has had 1.3.8+ since Fedora 28 (RHEL 8 as well, therefore) - Alpine has had 1.3.8+ since 3.9 Solvers will already have been picking conf-zstd.1.3.8 as the greatest version, so this commit explicitly marks conf-zstd.0.1 as unavailable, and removes the now-redundant version constraint on two old zstandard packages.
mseri
reviewed
Mar 12, 2024
| # conf-zstd. conf-zstd.1.3.8 was added to "encode" a build requirement of at | ||
| # least version 1.3.8, but this should have been done using an entirely new | ||
| # package. | ||
| available: false |
There was a problem hiding this comment.
can we just mark it as deprecated for now without changing the content or make it unavailable? There is not much of a point into using the deprecated flag otherwise imo.
And even in the case we really want to make it unavailable, which I am ok with, I'd prefer not to delete the rest of the content
There was a problem hiding this comment.
That makes a lot of sense - amendment just pushed. I can't remember if deprecated => avoid-version but we'll shortly find out from the lowerbounds check 🙂
ppxlib appears to be affected by a variation on ocaml/dune#1549, fixed by ocaml/dune#1551 Dune 1.6.0.
It's either that or adding x-ci-accept-failures!
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we move towards proper depext support for Windows in opam-repository, old versions of conf- packages are an increasing nuisance, as either they all need updating or old versions need constraining away from Windows for lowerbounds purposes (cf. #25235).
conf-zstd has two versions - the original conf-zstd.0.1 and then a version constraining conf-zstd.1.3.8 added in #13602.
In general, I find that these pseudo-version conf- packages add more maintenance burden/confusion than they solve. However, in this particular case, the passage of time means that pretty much any supported distro has at least version 1.3.8 (Ubuntu's had 1.3.8+ since Disco (19.04); Fedora has had 1.3.8+ since Fedora 28; Alpine has had 1.3.8+ since 3.9), so rather than just changing the constraint for the older conf-zstd.0.1, how about just simply disabling it?