Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch fixing lablgtk3 #178 #25574

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Conversation

garrigue
Copy link
Contributor

Recent versions of clang and gcc trigger a type error in a newly added function in ml_gtk.c (garrigue/lablgtk#178).
This commit adds a patch fixing that.
The fix is already merged in lablgtk3, but making a new release will take a while.

@mseri
Copy link
Member

mseri commented Mar 26, 2024

Thanks! Can you move these changes to packages/lablgtk3/lablgtk3.3.1.4-1/?

@garrigue
Copy link
Contributor Author

If I do that, then I need to also modify lablgtk3-{sourceview3,gtkspell3,rsvg2,goocanvas2} since they all depend on using the same version of lablgtk3.
This fix is only needed if somebody could not install lablgtk3.3.1.4. If the install was successful, it is not needed, and the code is unchanged. So couldn't we keep it just as fix, rather than a new version.
I will make a new version as soon as I have time to do it, but it may take a while, and in the midtime people cannot use lablgtk3 and dependents.

@mseri
Copy link
Member

mseri commented Mar 29, 2024

Ok, since this seems to be a (backward compatible) strict improvement and the patch is small enough, I think it is a reasonable compromise to merge it in the meantime

@mseri mseri merged commit a92d9df into ocaml:master Mar 29, 2024
1 of 2 checks passed
@mseri
Copy link
Member

mseri commented Mar 29, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants