[new release] passage (0.1.2)

[thatportugueseguy]

Passage - used to store and manage access to shared secrets

• Project page: https://github.com/ahrefs/passage

CHANGES:

• Update test config and add opam ci exclusions

[thatportugueseguy]

@mseri is this state good enough to merge? We are skipping the platforms we don't want to cater to at the moment. I'm not sure about the linting warning on the conf-age package, but I reckon there is no real possible name collision issue

Please let me know what else should be done to be able to merge this package. Thank you

[mseri]

Looks all right. Please ignore the lint failure in this case.

I'll try to re-run the builds in which the CI disconnected.

Do you know why x86_32 fails with

#=== ERROR while compiling passage.0.1.2 ======================================#
# context              2.3.0~alpha~dev | linux/x86_32 | ocaml-base-compiler.4.14.2 | pinned(https://github.com/ahrefs/passage/releases/download/0.1.2/passage-0.1.2.tbz)
# path                 ~/.opam/4.14/.opam-switch/build/passage.0.1.2
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p passage -j 255 @install @runtest
# exit-code            1
# env-file             ~/.opam/log/passage-7-7ff922.env
# output-file          ~/.opam/log/passage-7-7ff922.out
### output ###
# File "lib_test/dune", line 10, characters 1-15:
# 10 |  (inline_tests)
#       ^^^^^^^^^^^^^^
# (cd _build/.sandbox/a28aa5aee5cdcc4da0c0e007ecdeab9b/default/lib_test && .passage_test.inline-tests/inline_test_runner_passage_test.exe inline-test-runner passage_test -source-tree-root .. -diff-cmd -)
# Fatal error: exception File "network.ml", line 3, characters 9-15: Assertion failed
# Raised at Devkit_core__Network in file "network.ml", line 3, characters 9-36

?

[thatportugueseguy]

Do you know why x86_32 fails with

It's because of https://github.com/ahrefs/devkit/blob/master/network.ml#L3. The network module in devkit doesn't support 32bit architectures. Is this an issue?

[mseri]

If the rest of the library is usable, that's all right. I think it may be worth adding an error message in devkit instead of abruptly failing though.

[mseri]

Thanks

[thatportugueseguy]

I think it may be worth adding an error message in devkit instead of abruptly failing though.

Makes sense, will see to it 👌