Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added release 109.08.00 of packages of the core suite #369

Merged
merged 1 commit into from
Feb 6, 2013
Merged

Added release 109.08.00 of packages of the core suite #369

merged 1 commit into from
Feb 6, 2013

Conversation

ghost
Copy link

@ghost ghost commented Feb 5, 2013

rc1 packages. Tested on linux and osx.

I know that it still does not build on freebsd for example (I'll fix it for the next release) but I failed to set the os constraint to: "linux" | "darwin".

@samoht
Copy link
Member

samoht commented Feb 6, 2013

what error message did you get for the OS constraints ?

samoht added a commit that referenced this pull request Feb 6, 2013
Added release 109.08.00 of packages of the core suite
@samoht samoht merged commit b2c9687 into ocaml:master Feb 6, 2013
@ghost
Copy link
Author

ghost commented Feb 6, 2013

If I write:

os: ["linux" | "darwin"]

I get a parse error:

$ opam update
Synchronizing /home/jdimino/.opam/repo/default with http://opam.ocamlpro.com.
Synchronizing /home/jdimino/.opam/repo/js with /home/jdimino/code/opam-repository.
File /home/jdimino/.opam/opam/core.109.08.00~rc1.opam: Bad format! Expecting an OS constraint, got {string("linux") symbol(|) string("darwin")}

If I write:

os: ["linux" "|" "darwin"]

opam update works but the installation fails:

$ opam install core.109.08.00~rc1
Version 109.08.00~rc1 of "core" is incompatible with your compiler or your OS.
'opam install core.109.08.00~rc1' failed.

@samoht
Copy link
Member

samoht commented Feb 6, 2013

Good catch, this is now fixed (by OCamlPro/opam@00c0dc7)

@ghost
Copy link
Author

ghost commented Feb 6, 2013

Thanks, it fixes the parsing.

I found why opam install core.109.08.00~rc1 fails.

@avsm
Copy link
Member

avsm commented Feb 6, 2013

do we need to bump the repository version? this would break old opam clients...

@samoht
Copy link
Member

samoht commented Feb 6, 2013

the os constraints are not in the rc1 so no compatibilty problem for now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants