Patch rewrite tests #3456
Merged
Patch rewrite tests #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows debugging output to be trimmed to specific sections only. If the debug_sections map is empty, then debug_level applies to all sections. However, if the map is non-empty then only sections in the map will display debug messages, using debug_level if the mapped value is None.
Merged
|
The conflict comes from doc change for |
dra27
force-pushed
the
patch-rewrite-tests
branch
2 times, most recently
from
034e275
to
1f3f792
Compare
dra27
force-pushed
the
patch-rewrite-tests
branch
from
1f3f792
to
2e4ba75
Compare
rjbou
reviewed
Jun 24, 2019
rjbou
reviewed
Jun 25, 2019
dra27
force-pushed
the
patch-rewrite-tests
branch
from
585145c
to
ccd59dc
Compare
rjbou
reviewed
Jun 25, 2019
|
lgtm,thanks! |
dra27
force-pushed
the
patch-rewrite-tests
branch
from
8be49a3
to
7b4367e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits off the tests added in #3449. Three tasks remain for this PR:
The debug_sections should be converted to be an int option String.Map.t so that there is internally at least the option to have different levels for different sections.OPAMDEBUGSECTIONSneeds adding (either just supporting a list of sections, or full-blown support for specifying levels as well)