Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump src_ext Dune to 1.6.3 #3887

Merged
merged 1 commit into from Jun 27, 2019

Conversation

Projects
None yet
4 participants
@dra27
Copy link
Contributor

commented Jun 26, 2019

Allows compilation with OCaml 4.08.0 - this is for 2.0 branch only, master should be bumped to latest Dune (though there's some work to deal with the jbuild deprecation warning needed).

Bump src_ext Dune to 1.6.3
Allows compilation with OCaml 4.08.0.
@avsm

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

Thanks, I think it would be useful to cut this as a 2.0.5 point release

@avsm

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

Incidentally, why not just go up to latest Dune 1.10.x?

@dra27

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

Because the jbuild deprecation warning breaks building the man pages, and I'm still working on that fix!

@dra27

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

@avsm - presumably also OK to cut it as 2.0.4-1 release tarball and submit to homebrew, etc. directly? It feels odd to cut a release with no actual features or bug fixes.

@avsm

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

Just cherry pick in #3886 and you have a bugfix release :-) I think it's far easier for packaging if we're consistent with our versioning. For instance the -1 suffix is also used by debian as an extra version so it starts to clash.

@dra27

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

The version wouldn't change it - it's just a new release tarball and any version bumping in Debian is theirs to do. But you're right that a quick release can also be cut.

@avsm

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

Generally speaking, I view a build system upgrade as a reasonably major change -- there may be unexpected regressions or side effects that we don't anticipate. From a packagers perspective, newer versions of Dune may do something surprising that affects their packaging infrastructure and require some tweaks. A "recut" of a point release should be reserved for when we are absolutely sure there are no weird side effects (for example, documentation fixes or README changes or things of that nature).

@rjbou rjbou added this to the 2.0.5 milestone Jun 26, 2019

@AltGr AltGr merged commit a3b255a into ocaml:2.0 Jun 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.