Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Dune 1.7.0 and later #3888

Merged
merged 1 commit into from Jul 2, 2019

Conversation

Projects
None yet
4 participants
@dra27
Copy link
Contributor

commented Jun 26, 2019

Dune 1.7.0 displays a deprecation warning for jbuild files which needs to be suppressed when generating the man pages.

Fixes #3870.

Support Dune 1.7.0 and later
Dune 1.7.0 displays a deprecation warning for jbuild files which needs
to be suppressed when generating the man pages.
@dra27

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

I'd be grateful if someone with access to a Mac which isn't running GNU sed (or a BSD box in the same limited position!) could verify that that sed script is entirely POSIX.

@@ -43,7 +43,8 @@ man:
done
$(OPAM_INSTALLER) $(HELPFMT) > man/opam-installer.1 2>> man/err
# Dune doesn't (yet) support --no-print-directory

This comment has been minimized.

Copy link
@avsm

avsm Jun 26, 2019

Member

Is there an upstream dune pr for this --no-print-directory feature? Worth noting in the comment if so.

This comment has been minimized.

Copy link
@dra27

dra27 Jun 26, 2019

Author Contributor

It's in Dune 1.7.0 - on the master branch PR (coming shortly) for Dune 1.10, the comment is gone...

@avsm

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

I do have full dune ports of all the dependencies in src_ext in https://github.com/dune-universe/

Would it be better to just cut src_ext tarballs from those git repos instead?

@dra27

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

I know 🙂 I prefer the src_ext to remain upstream tarballs as far possible. The ones causing "pain" here are all packages which upstream were using jbuilder, so I expect all we need to do is update to their latest versions.

@dra27

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

(you're applying "master" reviewing to a maintenance branch!)

@rjbou rjbou added this to the 2.0.5 milestone Jun 26, 2019

@AltGr AltGr merged commit a23b975 into ocaml:2.0 Jul 2, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dra27 dra27 deleted the dra27:dune-1.7.0-support branch Jul 2, 2019

@dra27

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

It will of course be worth back-porting #3902 once it’s finalised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.