-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Dune 1.7.0 and later #3888
Conversation
Dune 1.7.0 displays a deprecation warning for jbuild files which needs to be suppressed when generating the man pages.
I'd be grateful if someone with access to a Mac which isn't running GNU sed (or a BSD box in the same limited position!) could verify that that |
@@ -43,7 +43,8 @@ man: | |||
done | |||
$(OPAM_INSTALLER) $(HELPFMT) > man/opam-installer.1 2>> man/err | |||
# Dune doesn't (yet) support --no-print-directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an upstream dune pr for this --no-print-directory
feature? Worth noting in the comment if so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in Dune 1.7.0 - on the master
branch PR (coming shortly) for Dune 1.10, the comment is gone...
I do have full dune ports of all the dependencies in src_ext in https://github.com/dune-universe/ Would it be better to just cut src_ext tarballs from those git repos instead? |
I know 🙂 I prefer the |
(you're applying "master" reviewing to a maintenance branch!) |
It will of course be worth back-porting #3902 once it’s finalised |
Dune 1.7.0 displays a deprecation warning for jbuild files which needs to be suppressed when generating the man pages.
Fixes #3870.