Preliminary support for Dune 2.0 #3965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporary fix - ultimately the post-processing of the .install file should be eliminated instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dune 2 only promotes the
.installif the-pis specified, which doesn't work for opam's build system. This commit detects whether the--promote-install-filesargument is available which isn't particularly pretty, but does mean that opam will build with both Dune 1.x and 2.x.Ultimately, it would be better to push for Dune features which eliminate the need for the post processing of the
.installfiles completely and then just depend on Dune 2.0.Addresses #3961