Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repo add/set-url: add --no-action #4933

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

repo add/set-url: add --no-action #4933

wants to merge 16 commits into from

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Nov 25, 2021

to not initialise the repo directly. It will be fetched on next update. See test file

@rjbou rjbou added the PR: WIP Not for merge at this stage label Nov 25, 2021
@rjbou rjbou added this to the 2.2.0~alpha milestone Nov 25, 2021
@rjbou rjbou requested a review from dra27 November 25, 2021 15:42
@rjbou rjbou added this to PR in progress in Opam 2.2.0 via automation Nov 25, 2021
@rjbou rjbou moved this from PR in progress to PR to review in Opam 2.2.0 Nov 25, 2021
@rjbou
Copy link
Collaborator Author

rjbou commented Dec 1, 2021 •
edited

TODO: add non initialised information to have a more specific error message

@rjbou rjbou moved this from PR to review to PR in progress in Opam 2.2.0 Dec 7, 2021
@rjbou rjbou moved this from PR in progress to PR to review in Opam 2.2.0 Dec 7, 2021
@rjbou rjbou added PR: QUEUED Pending pull request, waiting for other work to be merged or closed and removed PR: WIP Not for merge at this stage PR: NEEDS UPDATE labels Dec 7, 2021
@dra27
Copy link
Member

dra27 commented Dec 14, 2021

Note from an dev meeting (a few weeks ago 🙈): could possibly add a flag internally to the repo state so that we can identify the first opam update since the url was set so that the warning could be better (to differentiate, say, the network being down and not warning about all the URLs) i.e. allow opam to know the difference between "this URL has never worked / never been checked" and "this URL has started failing since last time"

@rjbou rjbou linked an issue Dec 16, 2021 that may be closed by this pull request
opam 2.1.0 has different behaviours on macOS on packages with mismatching version field #4780
Closed
@kit-ty-kate kit-ty-kate removed a link to an issue Dec 16, 2021
opam 2.1.0 has different behaviours on macOS on packages with mismatching version field #4780
Closed
@dra27
Copy link
Member

dra27 commented May 17, 2022

Cross-referencing #4617, which this will close!

@rjbou
add global upgrade status
03f3d30
@rjbou
fix opam upgrade root
b772ce7
@rjbou
reftests: some update to opam root version test
f0d0b9f 
* add repos-config file check
* add some comments
* add some global state rw commands
* update generator to handle repos-config and clean root
* fix --set-default that update config (instead of just updating repo config)
* add repos-config rw loading for last update
@rjbou
update changes
babd7c7
@rjbou
root version: upgrade to 2.2~alpha
64b46d5
@rjbou
format upgrade: generalise a little bit intermediate root handling
ea11ff4
@rjbou
reftests: update opam root with 2.2~alpha upgrade
c245ebd 
reftest: opam root add repo file check
@rjbou
update changes
beab9ae
@rjbou
repo: set-url and add with no-action
9d259b5
@rjbou
opampp: add map options with 4 arguments
8c92404
@rjbou
repo config: add a (first) optional argument to reposiroty, its initi…
a596e91 
…alisation state
dra27
dra27 reviewed Feb 7, 2023
View reviewed changes
src/state/opamFormatUpgrade.ml
let from_2_1_to_2_2_alpha_repo root _conf =
let f = OpamPath.repos_config root in
OpamStd.Option.iter (OpamFile.Repos_config.write f)
(OpamFile.Repos_config.read_opt f)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be iterated over to set all of the initialised fields to true, given that they must have been initialised before? (cf. the v1.3+ upgrade)?

@rjbou rjbou added this to PR in Progress in Opam 2.3 via automation Feb 7, 2023
@rjbou rjbou removed this from the 2.2.0~alpha milestone Feb 7, 2023
@rjbou rjbou added the PR: WIP Not for merge at this stage label Feb 7, 2023
@rjbou rjbou moved this from PR to review to PR in progress in Opam 2.2.0 Mar 1, 2023
@kit-ty-kate kit-ty-kate removed this from PR in progress in Opam 2.2.0 Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dra27 dra27 dra27 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
PR: QUEUED Pending pull request, waiting for other work to be merged or closed PR: WIP Not for merge at this stage
Projects
Opam 2.3
  
PR in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rjbou @dra27