Check that the repositories given to "opam repository remove" actually exist #5014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
reviewed
Jan 20, 2022
src/client/opamCommands.ml
Outdated
Comment on lines
2208
to
2224
| let seen_repos = ref [] in | ||
| let rm = | ||
| List.filter (fun n -> | ||
| (* TODO: Replace OpamRepositoryCommand.update_selection by | ||
| something that does not require dealing with such | ||
| horrible reference *) | ||
| let seen = List.mem n names in | ||
| if seen then begin | ||
| seen_repos := n :: !seen_repos; | ||
| end; | ||
| not seen) | ||
| in |
There was a problem hiding this comment.
I have in mind another way to do it without ref, i'll update later
There was a problem hiding this comment.
updated the pr, a draft / proposal
kit-ty-kate
commented
Jan 20, 2022
src/client/opamCommands.ml
Outdated
| | Some `remove, names -> | ||
| let names = List.map OpamRepositoryName.of_string names in | ||
| let rm = List.filter (fun n -> not (List.mem n names)) in | ||
| let seen_repos = ref [] in | ||
| let rm = |
There was a problem hiding this comment.
Actually this is not even called when the repository is not attached to a switch but exists in the global state so it returns an error even though it did something.
$ ./opam repo -a
[...]
tmp [...]
$ ./opam repo remove tmp -a
[ERROR] No repository named tmp
$ ./opam repo -a
[...]
[no tmp]
… actually exist" This reverts commit 2dccc99.
rjbou
force-pushed
the
check-repos-remove-exist
branch
from
d0cde13
to
6a0b06e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5012