opam root version: fix upgrade from a non global config change #5305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
added
PR: QUEUED
rjbou
added
PR: WAITING FOR REVIEW
and removed
PR: WIP
rjbou
removed
the
PR: QUEUED
rjbou
commented
Nov 22, 2022
rjbou
force-pushed
the
root-fx
branch
2 times, most recently
from
0efc815
to
afbcb56
Compare
1 task
rjbou
added
PR: WIP
dra27
reviewed
Feb 10, 2023
src/format/opamFile.ml
Outdated
| @@ -1760,25 +1760,44 @@ end | |||
| module Repos_configSyntax = struct | |||
|
|
|||
| let internal = "repos-config" | |||
| let format_version = OpamVersion.of_string "2.0" | |||
| let format_version = OpamVersion.of_string "2.1" | |||
There was a problem hiding this comment.
It would be better to bump it straight to 2.2, wouldn't it? (I think the "gap" is less confusing than having a 2.1 version of the format which technically can't be read by opam 2.1's libraries!)
There was a problem hiding this comment.
I don't remember what we say about those versions : should they follow opam versions ?
There was a problem hiding this comment.
I think the intention was that we'd use opam versions when it was bumped, yes - so it just so happened that opam 2.1 uses opam 2.0's repo config format
|
Updated |
Used to retrieve information about remaining upgrades to do (repo or switch)
When root is bumped but only repo or switch is modified, upgraded files can be written without writing the root bump (on-the-fly global state upgrade).
dra27
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.