Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the Markdown files in doc/pages to be amenable for use on OCaml.org #5593

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sabine
Copy link

@sabine sabine commented Jul 5, 2023

This patch does two one thing:

Note:

  • unless we can find another place to host the man pages long-term, I see no other viable option than to remove the references to the man pages. Maybe we do want to look for a place where they can be hosted long-term?
  • Hosting the markdown on ocaml.org is an interim solution only. When odoc is able to build the opam manual, ocaml.org will pull the opam manuals from docs-data.ocaml.org (the package documentation server).
  • sibling patch that generates markdown for the man-pages: Convert man pages to Markdown with YAML header #5594
  • corresponding work-in-progress patch on ocaml.org: Move opam docs from opam.ocaml.org ocaml.org#1367

@rjbou rjbou added the PR: WIP Not for merge at this stage label Jul 5, 2023
@sabine
Copy link
Author

sabine commented Jul 5, 2023

Thanks @rjbou. Indeed, this will change before it needs a review.

@rjbou
Copy link
Collaborator

rjbou commented Jul 5, 2023

On the man pages, is it possible to generate them and refer to them as doc md files ?

@rjbou
Copy link
Collaborator

rjbou commented Jul 5, 2023

On line editing, please update :D Documentation needs an update (for example, the Upgrade guide is quite obsolete on New features section). It is nice to have an external view, it helps to have something more understandable.

Is it possible to have different PRs, one for documentation update and the other that moves files around and update them (eg the header) to make it ocaml.org doc compliant ?

@sabine
Copy link
Author

sabine commented Jul 5, 2023

Ah, certainly, if the man pages can be turned into .md instead of HTML, that would work!

When the line editing is finished, I'll separate into two PRs, line editing to merge first, then this one.

@rjbou
Copy link
Collaborator

rjbou commented Jul 5, 2023

Perfect! Thanks!

@sabine sabine force-pushed the docs_move_ocaml_org branch 2 times, most recently from 5f9d573 to f39f2ed Compare July 5, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: WIP Not for merge at this stage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants