Add a verbose-on option. #5682
Add a verbose-on option. #5682
Conversation
rjbou
force-pushed
the
install-verbose-on
branch
from
4db9e45
to
c25a4e1
Compare
src/client/opamArg.ml
Outdated
| let verbose_on = | ||
| mk_opt ~cli (cli_from cli2_2) ~section ["verbose-on"] "PACKAGES" | ||
| "Be more verbose on specific packages." | ||
| Arg.(some (list package)) None ~vopt:(Some []) |
There was a problem hiding this comment.
Here you have verbose_on and a name & version opt list, but only names are used. It'll be better to take only name list. You can use OpamArg.name_list
| Arg.(some (list package)) None ~vopt:(Some []) | |
| Arg.(some name_list) None ~vopt:(Some []) |
There was a problem hiding this comment.
I think it would be better to allow full package name + version as it is currently. This way the feature would be much simpler to use, especially in CI systems where this would be most useful
There was a problem hiding this comment.
If we have name.version, it can be used only if user knows in advance which version of the package will be installed, which is not always the case.
In usual CI, you may want to have install log of the package you are testing (usually yours), and its inner version can change.
What do you have in mind about disadvantages of only name?
There was a problem hiding this comment.
ok fair, let's do name only for now, we can always add name.version later if we want or if requested
There was a problem hiding this comment.
It could evolve into name.optional-version, like that we have all advantages :)
|
I've added a test ( I've also rebased your PR, we prefer rebasing on master than merging master for PRs, it eases history/commits lookup. |
kit-ty-kate
added
PR: WAITING FOR REVIEW
and removed
PR: WIP
|
Thanks for your review, I did it a bit late... but I think there's nothing more to do about what you said, I'll however say I don't exactly know how to test env variables, and I'm not sure if what I did works (at least it compiles!) |
|
No worry! We'll try to review the changes in the next weeks. We are also focused on the 2.2 release on our side :) |
desumn
force-pushed
the
install-verbose-on
branch
from
88c67ec
to
7dc4421
Compare
|
It's been some time, do you have any update on this? |
|
Sorry for the delay, we are still diving into the release of 2.2 (that is in its beta2 since 2 days). I've put some comments, with these modification and an update of master_changes (points to add in Client, Reftests, and API), the PR should be nearly complete. |
|
Thanks for your reviews, I commited the changes. |
Co-authored-by: Raja Boujbel <raja.boujbel@ocamlpro.com>
rjbou
force-pushed
the
install-verbose-on
branch
from
1fc9017
to
e6c6afa
Compare
|
Now opam 2.2 is out, we can take a look again to other PRs @desumn. I've updated the PR: update some code, squashed intermediate commits, update changelog, etc. |
| ?verbose_on: | ||
| (b.verbose_on >>= function | ||
| | [] -> None | ||
| | vo -> Some (OpamPackage.Name.Set.of_list vo)) |
There was a problem hiding this comment.
Current behaviour I've implemented: if the flag list is empty, it is considered as nothing was given. Same for environment variable.
| ### : unknown package | ||
| ### opam reinstall qux --verbose-on unknown-pkg | unordered |
There was a problem hiding this comment.
On unknown package, nothing is printed, should we?
There was a problem hiding this comment.
I think the current behaviour is fine
kit-ty-kate
force-pushed
the
install-verbose-on
branch
from
e6c6afa
to
0d2588d
Compare
Implementation of #5331
Add a
verbose-on=PACKAGESparameters to build options. For the time being, it's equivalent to a simple-vfor a list of package.I'm not sure how I'd be able to simulate a modification of the opam file of a specific package to change add the verbose flag, so it's not exactly what #5331 asked for, however if there's a way I'd be glad to implement it!