-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CONTRIBUTING.md by adding some guidance into the codebase for people who want to contribute to the code #5858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR!!
597c7fd
to
dab2a97
Compare
c4baed7
to
7494a7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you - a few nits only
|
||
* http://lists.ocaml.org/listinfo/platform | ||
(for the both the tool & packages) | ||
### Releasing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be in the contributing guide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to have it here, than a release.md file that contains only a redirection to release/readme.md
…e for people who want to contribute to the code
0559de0
to
9d6d606
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'm unsure if there already was such documentation somewhere but in any case it could be a nice entry point for potential contributors
TODO-later:
shell/
(install.sh, bootstrap, "other scripts")