Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad coloring of module types #91

Closed
c-cube opened this issue Oct 20, 2022 · 2 comments
Closed

bad coloring of module types #91

c-cube opened this issue Oct 20, 2022 · 2 comments

Comments

@c-cube
Copy link
Collaborator

c-cube commented Oct 20, 2022

module Make : functor(X: Ord) -> sig
  module Bar : module type of Make(X)

  val x : int
  val y : int
end

looks like this (ie the whole signature of the module is red):
2022-10-20-105709_409x175_scrot

Could we revert the syntax file to the old version? The recent changes look nicer on some parts of OCaml, but they are really broken on a lot of module-related syntax. I think "first, do no harm" would be a sound policy here.

@Maelan
Copy link
Contributor

Maelan commented Nov 1, 2022

Actually there are 2 independent bugs here (functor and module type of), and they both existed prior to the new type linter. It’s just that type linting made these bugs more flashy. Anyway, the PR above fixes them both.

@copy
Copy link
Collaborator

copy commented Jan 24, 2023

Fixed in master.

@copy copy closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants