Add ocaml.server.duneDiagnostics to disable dune diagnostics reporting
#1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch will need some changes after #1321 but it also requires the LSP change, so I will be waiting to work on it again. |
|
@EduardoRFS Could you add a change log entry when you rebase this? 🙏 |
|
@smorimoto done, it would be great if we could get this merged and a release |
smorimoto
approved these changes
Jan 6, 2024
|
Looks good to me. I guess we also need their review. |
|
LGTM. Corresponding lsp PR is here ocaml/ocaml-lsp#1221 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I would like to disable dune diagnostics as mentioned in
ocaml/ocaml-lsp#1221
This also shines light in a bug, currently "vscode-ocaml-platform" doesn't push the configs when starting the server, making so that the config is only pushed when you change them. I will fix this in a future PR.
Related