Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix showing error message if ocaml-lsp is missing #586

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

mnxn
Copy link
Collaborator

@mnxn mnxn commented Apr 19, 2021

Closes #579

Using map instead of bind with no type annotation was causing the error message to be ignored. Using a normal promise (not a result promise) is simpler.

@mnxn mnxn requested review from tmattio and rgrinberg April 19, 2021 19:35
@mnxn mnxn merged commit 80e1b21 into ocamllabs:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension does not detect the absence of ocamllsp
3 participants