Modified the command to set the --set-switch flag

[SaySayo]

Modified the command to set the --set-switch flag. Fixes (#655). @tmattio @mnxn please review

[rgrinberg]

--set-switch set the switch globally right? If it does, setting OPAMSWITCH might be better.

[Khady]

If it does, setting OPAMSWITCH might be better.

With opam exec the --set-switch flag does chagne OPAMSWITCH

       --set-switch
           With the env and exec subcommands, also sets the OPAMSWITCH
           variable, making sure further calls to opam will use the same
           switch as this one.

[Khady]

the --set-switch flag is only needed on the calls to opam exec. So switch_arg doesn't need to be modified

[SaySayo]

You mean I pass the --set-switch flag to only the exec function and remove it from the switch_arg?

[Khady]

Yes. Basically the whole PR will become

- let exec t switch ~args = spawn t ("exec" :: switch_arg switch :: "--" :: args)
+ let exec t switch ~args = spawn t ("exec" :: switch_arg switch :: "--set-switch" :: "--" :: args)

[SaySayo]

Thanks! Made the corrections.

[Khady]

there's already switch_arg switch so you don't need to insert ["--switch=" ^ Switch.name switch; "--set-switch"] again. But actually for all those commands there's no use for --set-switch so this part of the diff can be removed.

[SaySayo]

Noted!

[Khady]

I'm not part of the team, so won't be the one validating your work. But thank you for the contribution!

[tmattio]

Thanks for the work @SaySayo and the review @Khady 🙂

This looks good to me, but @ulugbekna could you confirm that this is the expected fix for #655?

[ulugbekna]

Thanks, @SaySayo ! :-)