Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility conflict with upstream #6

Closed
ckastner opened this issue Apr 27, 2020 · 1 comment
Closed

Compatibility conflict with upstream #6

ckastner opened this issue Apr 27, 2020 · 1 comment

Comments

@ckastner
Copy link

Hi,

the Python module being built places svm, svmutil, and commonutil in its own namespace, instead of the global one. While reasonable (commonutil is a quite generic name, after all), this breaks code that expects svm and svmutil at their historical locations.

We've encountered this in Debian, with a dependent package expecting the new location. However, given that the old location has been around since 2006, switching our packaged python-libsvm to the new location could potentially break a lot of existing code, so we'll stick with upstream's version approach for now.

Please coordinate with upstream as to how best resolve this location conflict.

(If commonutil is the issue, one possible solution would be to integrate it into svmutil, as effectively, that is what happens within svmutil.py anyway.)
@ocampor
Copy link
Owner

ocampor commented Apr 28, 2020

Thanks for your comment. PRs are welcome! I will take a look myself.

otizonaizit added a commit to mdp-toolkit/mdp-toolkit that referenced this issue May 4, 2020
@otizonaizit
FIX: fix support for libsvm installed from upstream or from PyPI
e8020f1 
Upstream libsvm <https://github.com/cjlin1/libsvm/> and the upstream repo
for the package on PyPI <ocampor/libsvm#6> use
a different namespace: https://bugs.debian.org/958114 .

This commit fixes the detection of the libsvm library such that it works
for both installation ways, from PyPI or directly from upstream. The
python3-libsvm package in Debian is following upstream.
@otizonaizit otizonaizit mentioned this issue May 4, 2020
Merged
Stewori pushed a commit to mdp-toolkit/mdp-toolkit that referenced this issue May 28, 2020
@otizonaizit
FIX: fix support for libsvm installed from upstream or from PyPI (#83)
ad5bdd6 
Upstream libsvm <https://github.com/cjlin1/libsvm/> and the upstream repo
for the package on PyPI <ocampor/libsvm#6> use
a different namespace: https://bugs.debian.org/958114 .

This commit fixes the detection of the libsvm library such that it works
for both installation ways, from PyPI or directly from upstream. The
python3-libsvm package in Debian is following upstream.
Stewori added a commit to Stewori/mdp-toolkit that referenced this issue May 28, 2020
@Stewori @otizonaizit
Update from master (#15)
3b4b908 
* DOC: Point to the new website at https://mdp-toolkit.github.io. (mdp-toolkit#86)

* DOC: Point to the new website at https://mdp-toolkit.github.io.

* DOC: Updated two remaining references of the old sourceforge homepage to the new github homepage.

* FIX: fix support for libsvm installed from upstream or from PyPI (mdp-toolkit#83)

Upstream libsvm <https://github.com/cjlin1/libsvm/> and the upstream repo
for the package on PyPI <ocampor/libsvm#6> use
a different namespace: https://bugs.debian.org/958114 .

This commit fixes the detection of the libsvm library such that it works
for both installation ways, from PyPI or directly from upstream. The
python3-libsvm package in Debian is following upstream.

Co-authored-by: Tiziano Zito <otizonaizit@users.noreply.github.com>
@ocampor ocampor closed this as completed Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ocampor @ckastner