Added domain validation to rtrunc() #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wleoncio
added
enhancement
|
By the way, a convenient way to review the code is by following the numbers on this image (6 is optional, if you want to comment on a particular line).
|
…ameter-domains' of github.com:ocbe-uio/TruncExpFam into issue-7-Create-validation-function-for-distribution-parameter-domains
|
P.S.: not all functions are there, specifically those that need integration (see issue #30). These will be added later. |
…ameter-domains' of github.com:ocbe-uio/TruncExpFam into issue-7-Create-validation-function-for-distribution-parameter-domains
Updating the issue-7 branch with all the new stuff on develop. This should really be merged soon (depending on PR #39).
…stribution-parameter-domains
This was referenced Aug 16, 2021
wleoncio
deleted the
issue-7-Create-validation-function-for-distribution-parameter-domains
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi René,
I've written an internal generic function that handles parameter domain validation checks for each distribution handled by the package. It gets called whenever the user calls
rtrunc().I would like your help checking the validating conditions, especially the limit cases (e.g., whether or not to include 0s and 1s). I've used the limits from Wikipedia. I am also not sure whether the lambda in the Poisson must be an integer: I understand the function is supported only for a natural number of observations (X), but the mean/variance (lambda) can be any real number larger than zero.
Best,
Waldir
P.S.: This fixes issue #7