Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double write buffer #367

Merged
merged 24 commits into from
Apr 15, 2024
Merged

double write buffer #367

merged 24 commits into from
Apr 15, 2024

Conversation

Wenbin1002
Copy link
Contributor

What problem were solved in this pull request?

Issue Number: close #334

Problem:

What is changed and how it works?

实现double write buffer以解决页面的原子写入问题。

Other information

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 82.29167% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 37.62%. Comparing base (ab25a46) to head (eb175ca).
Report is 1 commits behind head on main.

❗ Current head eb175ca differs from pull request most recent head b5da6d7. Consider uploading reports for the commit b5da6d7 to get more accurate results

Files Patch % Lines
src/observer/storage/buffer/disk_buffer_pool.cpp 80.89% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   37.07%   37.62%   +0.54%     
==========================================
  Files         102      103       +1     
  Lines        7279     7360      +81     
==========================================
+ Hits         2699     2769      +70     
- Misses       4580     4591      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hnwyllmm hnwyllmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

抱歉还没有review完,有一些review可以先修改一下。

src/observer/storage/buffer/disk_buffer_pool.cpp Outdated Show resolved Hide resolved
src/observer/storage/buffer/disk_buffer_pool.cpp Outdated Show resolved Hide resolved
src/observer/storage/buffer/disk_buffer_pool.cpp Outdated Show resolved Hide resolved
src/observer/storage/buffer/disk_buffer_pool.cpp Outdated Show resolved Hide resolved
src/observer/storage/buffer/disk_buffer_pool.cpp Outdated Show resolved Hide resolved
src/observer/storage/buffer/page.h Outdated Show resolved Hide resolved
src/observer/storage/buffer/page.h Outdated Show resolved Hide resolved
src/observer/storage/buffer/page.h Outdated Show resolved Hide resolved
src/observer/storage/buffer/disk_buffer_pool.cpp Outdated Show resolved Hide resolved
src/observer/storage/buffer/disk_buffer_pool.cpp Outdated Show resolved Hide resolved
@hnwyllmm hnwyllmm self-requested a review April 7, 2024 02:47
src/observer/storage/buffer/disk_buffer_pool.cpp Outdated Show resolved Hide resolved
src/observer/storage/buffer/disk_buffer_pool.cpp Outdated Show resolved Hide resolved
src/observer/storage/buffer/disk_buffer_pool.cpp Outdated Show resolved Hide resolved
@hnwyllmm hnwyllmm merged commit a85cca5 into oceanbase:main Apr 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] buffer pool page原子写入问题
2 participants