Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dlm): task status is wrong #3491

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Conversation

guowl3
Copy link
Collaborator

@guowl3 guowl3 commented Sep 20, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

task framework refresh the results updates the task status, causing it to become abnormal.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@guowl3 guowl3 added the type-bug Something isn't working label Sep 20, 2024
@guowl3 guowl3 added this to the ODC 4.3.2 milestone Sep 20, 2024
@guowl3 guowl3 self-assigned this Sep 20, 2024
@yhilmare
Copy link
Contributor

you may check if your target branch is right or not~

@guowl3
Copy link
Collaborator Author

guowl3 commented Sep 23, 2024

you may check if your target branch is right or not~

sure, this fix needs to be merged into version 4.3.2 & obcloud-202409

Copy link
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@kiko-art kiko-art left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit acf70aa into dev/4.3.x Sep 23, 2024
7 checks passed
@yhilmare yhilmare deleted the tianke_432_fix_task_status_is_wrong branch September 23, 2024 07:51
guowl3 added a commit that referenced this pull request Sep 23, 2024
* fix the issue of wrong task status

* format

* fix the issue of throw not found exception when database is deleted.

* simplify code
yhilmare pushed a commit that referenced this pull request Sep 23, 2024
* fix the issue of wrong task status

* format

* fix the issue of throw not found exception when database is deleted.

* simplify code
guowl3 added a commit that referenced this pull request Sep 24, 2024
* fix the issue of wrong task status

* format

* fix the issue of throw not found exception when database is deleted.

* simplify code
yhilmare pushed a commit that referenced this pull request Sep 24, 2024
* fix(schedule): risk level mismatch when operating a schedule (#3529)

* fix select risklevel failed

* fix description

* fix(dlm): task status is wrong (#3491)

* fix the issue of wrong task status

* format

* fix the issue of throw not found exception when database is deleted.

* simplify code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants