You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we specify a different hour though, e.g. noon then the hours are ignored:
data=ioc.get_ioc_station_data("scor", endtime=pd.Timestamp("2023-05-04T12:00:00"), period=0.1)
data.time.min().time() # We still get 21:37 instead of ~09:37data.time.max().time() # We still get 23:57 instead of ~11:57
This involves several changes:
1. We rename `resolve_date` to `resolve_timestamp` since we no longer only deal with dates
2. The signature and the type of returned objects in`resolve_timestamp()` has changed.
More specifically the function became quite a bit more capable and complex.
It gained extra arguments that allow it to return both timezone-aware and
naive Timestamps.
3. We change the Literal value `TODAY` to `now`
Fixesoceanmodeling#96
This involves several changes:
1. We rename `resolve_date` to `resolve_timestamp` since we no longer only deal with dates
2. The signature and the type of returned objects in`resolve_timestamp()` has changed.
More specifically the function became quite a bit more capable and complex.
It gained extra arguments that allow it to return both timezone-aware and
naive Timestamps.
3. We change the Literal value `TODAY` to `now`
Fixesoceanmodeling#96
our
resolve_date()
function is accepting hours/minutes/seconds but it silently ignores them. This can be seen in the following examples.When we use a specific "Date" then, correctly, endtime is assumed to be at midnight and this is the behavior we get:
If we specify a different hour though, e.g. noon then the hours are ignored:
This is the relevant code:
searvey/searvey/utils.py
Lines 43 to 48 in c3f547b
The text was updated successfully, but these errors were encountered: