-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add main COOPS API for metadata #123
Add main COOPS API for metadata #123
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 90.04% 90.18% +0.13%
==========================================
Files 13 13
Lines 1015 1049 +34
Branches 151 155 +4
==========================================
+ Hits 914 946 +32
- Misses 55 56 +1
- Partials 46 47 +1 ☔ View full report in Codecov by Sentry. |
8f7ade4
to
924543d
Compare
Looks good. I would just rename the tests from |
Thanks for your feedback. I also realized I haven't updated |
Fixes #110
Currently the COOPS module uses COOPS's NWS product to get the station metadata:
https://access.co-ops.nos.noaa.gov/nwsproducts.html?type=current
This url doesn't have information about some of the stations. We need to use the main metadata URL:
https://api.tidesandcurrents.noaa.gov/mdapi/prod/webapi/stations.json
see documentation at https://api.tidesandcurrents.noaa.gov/mdapi/prod/