Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config refactor #51

Merged
merged 10 commits into from
Aug 12, 2020
Merged

config refactor #51

merged 10 commits into from
Aug 12, 2020

Conversation

kremalicious
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Aug 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/oceanprotocol/market/9tf9mk8ac
✅ Preview: https://market-git-feature-config.oceanprotocol.vercel.app

@mihaisc
Copy link
Contributor

mihaisc commented Aug 11, 2020

can you please take a look, there are some wierd errors from gatsby/webpack i think. And locally i get the classic react error : "Unhandled Rejection (Error): Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:" and i have no ideea why, i got this from the moment i pulled the branch. Main seems to be ok.

@mihaisc
Copy link
Contributor

mihaisc commented Aug 12, 2020

great, thanks. So things seem to update properly when changing network, except asset list. Asset list doesn't update because we use the same aquarius. When we move to main there will be a production aquarius so everything will update properly. So basically we switch from prod to test just by changing network from main to rinkey, pretty cool.

@mihaisc mihaisc marked this pull request as ready for review August 12, 2020 06:46
@mihaisc mihaisc self-requested a review as a code owner August 12, 2020 06:46
@mihaisc mihaisc merged commit 920d5c5 into main Aug 12, 2020
@mihaisc mihaisc deleted the feature/config branch August 12, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants