Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/ Mnemonic - Private key & Provider - Aquarius usage #29

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Fix/ Mnemonic - Private key & Provider - Aquarius usage #29

merged 6 commits into from
Oct 10, 2023

Conversation

bogdanfazakas
Copy link
Member

@bogdanfazakas bogdanfazakas commented Oct 10, 2023 •
edited
Loading

Fixes #22 #26 #25 #24 .

Changes proposed in this PR:

  • update readme for Mnemonic & Private key
  • fix aquarius url have default value
  • use provider url from dataset DDO when download method is used
  • use provider url from dataset DDO when using c2d also check if assets are serverd by the same provider in case of compute type
  • make more clear the need for custom urls when using barge components on macOS

This was referenced Oct 10, 2023
Closed
Merged
@bogdanfazakas bogdanfazakas changed the title Fix/various fixes Fix/ Mnemonic - Private key & Provider - Aquarius usage Oct 10, 2023
@bogdanfazakas bogdanfazakas marked this pull request as ready for review October 10, 2023 13:03
This was linked to issues Oct 10, 2023
Download: Improper use of provider #24
Closed
Compute: Improper use of provider #25
Closed
The aquarius-url doesn't have a default value #26
Closed
@LoznianuAnamaria LoznianuAnamaria merged commit cf9f7ab into main Oct 10, 2023
@LoznianuAnamaria LoznianuAnamaria deleted the fix/various-fixes branch November 15, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoznianuAnamaria LoznianuAnamaria LoznianuAnamaria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bogdanfazakas @LoznianuAnamaria @alexcos20