-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sidebar to sim plots dash UI #1112
Conversation
@KatunaNorbert could you post screenshots please? I'm afk but can review by phone then. Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for posting the screenshots!
Looks great!
@KatunaNorbert since dbc is now a dependency, could we add at least the stylesheet? |
elements = elements + arrange_figures(figures) | ||
|
||
return elements | ||
aranged_figures = arrange_figures(figures) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do a different arrangement. There's no point in keeping the old one if it doesn't apply. And actually I would transform it into a dict (key is category/tab, value is a list of figures)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then tabs would also be much easier to form
|
||
|
||
def get_tabs_component(elements): | ||
return dcc.Tabs( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could also use dbc Tabs for consistency with the lake dash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a look now at dbc Tabs and I'll prefer to use dcc because is offers more flexibility.
An impactful example is that dbc doesn't offer the option to display the tabs vertically on the left side.
Any type of font you prefer? |
I think we can use the stylesheet from dbc, which should be consistent |
I added the style dependency, also specified a font style that, we could change it up if we want in the future |
Fixes #1021.