Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sidebar to sim plots dash UI #1112

Merged
merged 8 commits into from
Jun 5, 2024
Merged

Conversation

KatunaNorbert
Copy link
Member

Fixes #1021.

@KatunaNorbert KatunaNorbert marked this pull request as ready for review June 3, 2024 08:18
@trentmc
Copy link
Member

trentmc commented Jun 3, 2024

@KatunaNorbert could you post screenshots please? I'm afk but can review by phone then. Thanks,

@KatunaNorbert
Copy link
Member Author

Screenshot 2024-06-03 at 11 23 18 Screenshot 2024-06-03 at 11 23 33 Screenshot 2024-06-03 at 11 23 43

Copy link
Member

@trentmc trentmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for posting the screenshots!

Looks great!

@calina-c
Copy link
Contributor

calina-c commented Jun 3, 2024

@KatunaNorbert since dbc is now a dependency, could we add at least the stylesheet?
it really bugs me to have that Times New Roman 90's html look 😅

elements = elements + arrange_figures(figures)

return elements
aranged_figures = arrange_figures(figures)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do a different arrangement. There's no point in keeping the old one if it doesn't apply. And actually I would transform it into a dict (key is category/tab, value is a list of figures)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then tabs would also be much easier to form



def get_tabs_component(elements):
return dcc.Tabs(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also use dbc Tabs for consistency with the lake dash

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look now at dbc Tabs and I'll prefer to use dcc because is offers more flexibility.
An impactful example is that dbc doesn't offer the option to display the tabs vertically on the left side.

@KatunaNorbert
Copy link
Member Author

@KatunaNorbert since dbc is now a dependency, could we add at least the stylesheet? it really bugs me to have that Times New Roman 90's html look 😅

Any type of font you prefer?

@calina-c
Copy link
Contributor

calina-c commented Jun 3, 2024

@KatunaNorbert since dbc is now a dependency, could we add at least the stylesheet? it really bugs me to have that Times New Roman 90's html look 😅

Any type of font you prefer?

@KatunaNorbert since dbc is now a dependency, could we add at least the stylesheet? it really bugs me to have that Times New Roman 90's html look 😅

Any type of font you prefer?

I think we can use the stylesheet from dbc, which should be consistent

@KatunaNorbert
Copy link
Member Author

KatunaNorbert commented Jun 3, 2024

I think we can use the stylesheet from dbc, which should be consistent

I added the style dependency, also specified a font style that, we could change it up if we want in the future

@KatunaNorbert KatunaNorbert merged commit 13edcfc into main Jun 5, 2024
5 checks passed
@KatunaNorbert KatunaNorbert deleted the issue-1032-sim-plots-sidebar branch June 5, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sim plots] Too many plots at once; fix via >1 page selectable via sidebar
3 participants