Update & add READMEs for remote mainnet #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
trentmc
requested changes
Oct 5, 2023
There was a problem hiding this comment.
Changes requested:
- update "get-ocean-on-sapphire.md", see comment
- update "get-rose-on-sapphire.md", see comment
- AND: in "azure-container-deployment.md", rename "Getting test tokens" to "Getting tokens". Have one paragraph for test tokens (like you have now), and another for mainnet tokens (new).
READMEs/get-rose-on-sapphire.md
Outdated
| @@ -0,0 +1,22 @@ | |||
| # Get ROSE tokens on Sapphire Mainnet | |||
|
|
|||
| ## Get ROSE tokens on Oasis Emerald Network | |||
There was a problem hiding this comment.
Above, I give tips for "get-ocean-on-sapphire". Please apply those tips to this README too.
trentmc
requested changes
Oct 5, 2023
Comment on lines
9
to
20
| The Sapphire network is EVM (Ethereum Virtual Machine) compatible, you'll need to fund your EVM compatible wallet from the faucet in order to submit predictions to the smart contract. | ||
|
|
||
| #### Getting test tokens on Sapphire test network | ||
|
|
||
| Follow the [faucet guide](./testnet-faucet.md) to fund your wallet with test ROSE and OCEAN. | ||
|
|
||
| #### Getting OCEAN and ROSE on Sapphire Mainnet | ||
|
|
||
| The Sapphire network is EVM (Ethereum Virtual Machine) compatible, you'll need to fund your EVM compatible wallet from the faucet in order to submit predictions to the smart contract. | ||
|
|
||
| - Check out the [Get ROSE on Sapphire Mainnet](./get-rose-on-sapphire.md) guide to get ROSE on mainnet. | ||
| - Check out the [Get OCEAN on Sapphire Mainnet](./get-ocean-on-sapphire.md) guide to get OCEAN on mainnet. |
There was a problem hiding this comment.
Suggest revising to:
### Getting Tokens
Sapphire accounts and wallets follow EVM standard.
Your wallet account on Sapphire needs both ROSE (for gas) and OCEAN (for using Predictoor).
- On Sapphire testnet, get (fake) [ROSE & OCEAN via the faucet guide](./testnet-faucet.md).
- On Sapphire mainnet, get [ROSE via this guide](get-rose-on-sapphire.md) and [OCEAN via this guide].(get-ocean-on-sapphire.md)
Why: same info and half the characters = easier to read:)
READMEs/backend-dev.md
Outdated
Comment on lines
112
to
114
| To get ROSE tokens on Sapphire Mainnet: see [get-rose-on-sapphire.md](get-rose-on-sapphire.md) | ||
|
|
||
| To get OCEAN tokens on Sapphire Mainnet: see [get-ocean-on-sapphire.md](get-ocean-on-sapphire.md) |
There was a problem hiding this comment.
Replace with:
Get [ROSE via this guide](get-rose-on-sapphire.md) and [OCEAN via this guide](get-ocean-on-sapphire.md).
READMEs/dfbuyer.md
Outdated
Comment on lines
65
to
67
| To get ROSE tokens on Sapphire Mainnet: see [get-rose-on-sapphire.md](get-rose-on-sapphire.md) | ||
|
|
||
| To get OCEAN tokens on Sapphire Mainnet: see [get-ocean-on-sapphire.md](get-ocean-on-sapphire.md) |
There was a problem hiding this comment.
Replace with:
Get [ROSE via this guide](get-rose-on-sapphire.md) and [OCEAN via this guide](get-ocean-on-sapphire.md).
READMEs/get-ocean-on-sapphire.md
Outdated
|
|
||
| ## 1. Get OCEAN on Eth Mainnet | ||
|
|
||
| ### 1. Create a Wallet |
There was a problem hiding this comment.
Change 1. to 1.1.
Similar for others, for 1.2, 2.1, 2.2, etc.
Why: much easier to understand context.
READMEs/predictoor.md
Outdated
Comment on lines
112
to
114
| To get ROSE tokens on Sapphire Mainnet: see [get-rose-on-sapphire.md](get-rose-on-sapphire.md) | ||
|
|
||
| To get OCEAN tokens on Sapphire Mainnet: see [get-ocean-on-sapphire.md](get-ocean-on-sapphire.md) |
There was a problem hiding this comment.
Replace with:
Get [ROSE via this guide](get-rose-on-sapphire.md) and [OCEAN via this guide](get-ocean-on-sapphire.md).
READMEs/trader.md
Outdated
Comment on lines
67
to
69
| To get ROSE tokens on Sapphire Mainnet: see [get-rose-on-sapphire.md](get-rose-on-sapphire.md) | ||
|
|
||
| To get OCEAN tokens on Sapphire Mainnet: see [get-ocean-on-sapphire.md](get-ocean-on-sapphire.md) |
There was a problem hiding this comment.
Replace with:
Get [ROSE via this guide](get-rose-on-sapphire.md) and [OCEAN via this guide](get-ocean-on-sapphire.md).
trentmc
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61
Changes proposed in this PR: