Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#229 - Test trueval agent batch.py gets stuck in infinite loop #367

Merged
merged 10 commits into from
Nov 22, 2023
Merged

#229 - Test trueval agent batch.py gets stuck in infinite loop #367

merged 10 commits into from
Nov 22, 2023

Conversation

trizin
Copy link
Contributor

@trizin trizin commented Nov 15, 2023 •
edited
Loading

Fixes #229

Changes proposed in this PR:

  • Patched wait_until_subgraph_syncs in test_take_step
  • Unskipped all trueval batch tests.
  • Tried running the flow more than 15 times, no infinite loops so far.

@trizin trizin linked an issue Nov 15, 2023 that may be closed by this pull request
[BUG] CI on test_trueval_agent_batch.py gets stuck in infinite loop #229
Closed
@trizin trizin marked this pull request as ready for review November 21, 2023 12:34
@trizin trizin requested a review from trentmc November 21, 2023 12:34
trentmc
trentmc approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@trentmc trentmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@trizin trizin merged commit 76a225e into main Nov 22, 2023
5 checks passed
@trizin trizin deleted the issue229-bug-ci-on-test_trueval_agent_batchpy-gets-stuck-in-infinite-loop branch November 22, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentmc trentmc trentmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] CI on test_trueval_agent_batch.py gets stuck in infinite loop
2 participants
@trizin @trentmc