Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add black, mypy and pylint workflow #37

Merged
merged 10 commits into from
Aug 15, 2023
Merged

Add black, mypy and pylint workflow #37

merged 10 commits into from
Aug 15, 2023

Conversation

trizin
Copy link
Contributor

@trizin trizin commented Aug 15, 2023 •
edited
Loading

Fixes #36

Changes proposed in this PR:

  • Add black, mypy and pylint workflow

@trizin trizin linked an issue Aug 15, 2023 that may be closed by this pull request
Add black and pylint flow #36
Closed
@trizin trizin marked this pull request as ready for review August 15, 2023 11:13
@trizin trizin requested review from trentmc and removed request for trentmc August 15, 2023 11:13
@trizin trizin marked this pull request as draft August 15, 2023 11:13
trentmc
trentmc approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@trentmc trentmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming that tests are passing when you merge. (I see that pylint is currently failing)

@trizin trizin changed the title Add black and pylint workflow Add black, mypy and pylint workflow Aug 15, 2023
@trizin trizin marked this pull request as ready for review August 15, 2023 11:41
@trizin trizin merged commit 023d7da into main Aug 15, 2023
4 checks passed
@trizin trizin deleted the issue36-add-black-and-pylint-flow branch August 15, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentmc trentmc trentmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add black and pylint flow
2 participants
@trizin @trentmc