Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#430 - Do not fetch pending slots older than 3 days #431

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

trizin
Copy link
Contributor

@trizin trizin commented Dec 1, 2023

Fixes #430

Changes proposed in this PR:

  • Do not fetch pending slots older than 3 days

@alexcos20 alexcos20 self-requested a review December 1, 2023 13:53
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, we need a way of updating old slots to 'Canceled'..
our predictors rely on subgraph to claim their rewards. but if we just choose to ignore old slots, they will not be updated by the graph and users will never get their money back..

On a 2nd look, payout will trigger all unpaid slots, so somebody "will" change the status of the slot.
Let's go ahead and merge then

@alexcos20 alexcos20 self-requested a review December 1, 2023 13:56
@alexcos20 alexcos20 merged commit 826ce70 into main Dec 1, 2023
5 checks passed
@alexcos20 alexcos20 deleted the issue430-do-not-get-pending-slots-older-than-3-days branch December 1, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Trueval bot] Do not get pending slots older than 3 days
2 participants