Fix #702: Check balances before submitting a prediction

[trizin]

Fixes #702

• Abort prediction submission if one of the wallets has insufficient balance

[trizin]

Gonna be ready for review once #733 is merged

[trentmc]

Make this simpler: have new properties to conveniently get the addresses. And keep the names shorter. That is:

@property
def up_addr(self) -> str:
        return self.web3_config_up.owner

@property
def down_addr(self) -> str:
        return self.web3_config_down.owner

Which means you can delete

        up_predictoor_address = self.web3_config_up.owner
        down_predictoor_address = self.web3_config_down.owner

and instead make calls to the properties instead.

[trentmc]

Let's aim to make variable names shorter, yet just as informative. Some guidelines...

Whenever we use token amounts, use capital letters.

And for "native" tokens we can be specific to Sapphire, since that's all Predictoor will be on for the foreseeable future.

Therefore "ocean" -> "OCEAN", and "native" -> "ROSE".

"balance" can be "bal"; "minimum" can be "min".

"bal" should be after "OCEAN" or "ROSE".

We don't need to say "predictoor" because "up" and "down" will implicitly tell enough.

Therefore we can relabel:

• "up_predictoor_balance_ocean" -> "up_OCEAN_bal"
• "down_predictoor_balance_ocean" -> "down_OCEAN_bal"
• "minimum_ocean_balance" -> "min_OCEAN_bal"
• "minimum_native_balance" -> "min_ROSE_bal"

---

Second, please use the new currency types "Eth" and "Wei". Will minimize chance of error.

Do this throughout all your changes please.

---

With the two suggestions above, the two lines above look like:

        min_OCEAN_bal = self.ppss.predictoor_ss.stake_amount # in units of Eth
        min_ROSE_bal = Eth(1) # in units of Eth

[trizin]

All done 🙌 thanks!

I couldn't find the part where new currency types "Eth" and "Wei" weren't used. Could you please point out that part so I can fix it?

Please note that balanceOf returns Wei.

[trentmc]

Change all log messages such that they take up 1 line.

[trizin]

I'm not sure if it's possible to shrink this message to a single line.

edit: Removed "predictoor's" from the message, that did it

[trentmc]

Rename "up_ocean, down_ocean, up_native, down_native, expected"

to

"up_OCEAN, down_OCENA, up_ROSE, down_ROSE, expected"

(in line with my previous comment)

[trentmc]

As discussed in standup, add two new properties: OCEAN() and ROSE(). From that, you'll be able to simplify check_balances() further. Including: you won't need local variables for balances or tokens.

[trentmc]

See new comment