-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expert eyes #3
Comments
@ocefpaf, I'm happy to review it. But this notebook doesn't include any results; oddly, none of the cells are numbered, either. Reviewing a notebook that doesn't show results is kind of tricky, and probably not very useful. If you could share with me the environment.yml file you used to run this notebook, even better. BTW, I see you're now using Bokeh? Cool. I've never used it myself. |
Sorry @emiliom I was going to push a new run but found an error in my workflow while doing that. Here is the latest (and partily fixed) run: http://nbviewer.ipython.org/urls/gist.githubusercontent.com/ocefpaf/727e00bb5ad27e022034/raw/9dd04d012cc66b7d1469968ae8326c65fa6d417e/IOOS_data_demo.ipynb |
Awesome, thanks! What's the best way for me to comment on this? I wish I could annotate a notebook inline ... Maybe I can import and run the notebook on my end, add comments on each cell, and send it back to you (post it on my gists)? I have several comments and questions already. One broad comment off the bat: I'm puzzled why no stations from the NANOOS SOS are returned by the CSW query. That doesn't make sense to me, but it's not something I've explored recently (ie, searching via the NGDC CSW). I've noticed that i52North SOS endpoints don't appear much in the system-test examples you've posted on the SIT blog, and that's also been puzzling. I'm very glad the CMOP SELFE model end point does show up! So, should I create an env using the IOOS environment.yml, and just add Bokeh? Or is it easier if you share your own env? |
Another general comment: there seems to be quite a bit of functionality in the |
@ocefpaf, I've been playing around with your notebook (I installed the IOOS env). Lots of interesting findings. But for now I have what's hopefully a simple CSW question: How do I encode a variable name to be added to |
Ignore that. Sorry to bug. |
Damn you, @ocefpaf 😉. You've made me "waste" a lot of time looking into many of the details going on in that notebook! The good news is that I think I've made much progress:
Stay tuned ... I'll try to share a notebook with you by Wednesday. |
Great! And now that I am back to this I see that I got way more that I expected! Thanks @emiliom!!
Hopefully is was not the case of the missing
I am keen to kill as much
Cool.
Thanks @emiliom! And sorry for all the trouble!! PS: Every time we run this kind of exercise we find something to fix, right @rsignell-usgs. |
Pinging @jenniferbosch here. Jen, do you know Kathy's GitHub username? |
Yes, @ocefpaf, it's by running actual tests like this that we discover the problems. I'd like to suggest to the ioos_tech mailing list that DMAC leads try running this notebook, switching the bounding box to their region, and make sure that they can get everything they think they should be getting. Are we ready for that or would you like to wait a bit more? |
@rsignell-usgs Give me 2-3 days. I want to put togehter a simpler notebook with that purpose in mind. |
@emiliom I see |
@ocefpaf - Kathy's Gihub username is @kbailey-noaa. This notebook looks good. @rsignell-usgs - Thank you for helping Filipe debug this. The more we can use pyoos instead of the utilities functions the better. As I understand it, Filipe is in the process of cleaning utilities functions up. |
@emiliom For annotations we can try https://via.hypothes.is. Click on the URL below, take a look at the upper right tools, and try to add a comment. I confess I never used it myself, but I do get URL feedback from it a lot.
Regarding the env, I am not done with
💯 |
@emiliom I am thinking about using |
@ocefpaf, the pyoos NDBC collector already uses Unless you're a pyoos pro, much of that won't make much sense to you! I'll share a cleaned-up NDBC pyoos notebook by tomorrow. |
And thanks for pointing me to https://via.hypothes.is ! I didn't know about that system. |
@ocefpaf, I've used via.hypothesis.is to make comments on the notebook. I'm hoping to share with you today a notebook on pyoos NDBC parsing, using the same OOI Endurance Array region as in your notebook. |
BTW, I will also share with you later (next week) the code or notebook to parse and plot the time series returned by the NANOOS SOS (ie, an IOOS-SOS compliant server) via the pyoos IoosSweSos collector. |
@ocefpaf: It took me a while, but finally here's the pyoos |
Got it. I guess pyoos could use some love...
Nice. I was hacking my way into SensorML without pyoos. As you know, pyoos has great docs 😉
I am not a pyoos pro! That notebook will be very useful.
I had a second intention when I showed that to you. To get feedback on the system-test pages 😜 A quick look at your notebook already gave me many ideas to improve this one. Thanks! @kbailey-noaa I will have something ready for you soon. |
Understatement ... BTW, much of the SensorML machinery comes from OWSLib, though it looks like the IoosSweSos collector includes some additional convenience parsing for SensorML for the IOOS SOS conventions. Regarding my use of via.hypothesis.is, you'll notice that I didn't fully know how to use it when I commented on your notebook. I didn't know how to link notes to specific text. I learned that later. I started working on a notebook demoeing pyoos with the NANOOS 52N SOS, but I've run into problems. First, I had never used pyoos with a bounding box request on a 52N SOS server. I got an error from pyoos (before it issued the request to the server). When testing directly on my server, I'm running into other issues, including Feliz Natal! |
@ocefpaf, for the NANOOS 52N SOS / pyoos IoosSweSos notebook demo I'm creating, I'm adapting another notebook I created a couple of months ago. That one is too messy to share, but it did work (on a single station). If you're impatient or too curious, here are some old (early 2014) notebooks of mine using pyoos IoosSweSos, on Wakari: pyoos_ioos_sos_demo1, and a much messier but complementary pyoos_swesos_axiom52north_test_2 |
I am interested into hearing more about these problems. Maybe we can create a post on
Not as messy as you think. Those are very helpful! Feliz Natal e Bom Ano Novo! |
@ocefpaf: a couple of additional comments about the latest, near-final notebook you mentioned in #2:
|
Yes. I am trying to improve that. (The function is already ugly as is, but...) |
If I manage to get fix the NANOOS SOS server today, I'll contribute code tomorrow to fix collector2table so it can ingest from the |
@rsignell-usgs, maybe I'm misunderstanding this. I already have a registered NANOOS WAF with other records. Are you saying that if I just extract the OSU ROMS THREDDS iso (from its own, updated ncISO) and dump it on my WAF, that would be enough? Wouldn't that risk creating a duplicate record, though (2 iso records with the same doc ID)? If doing this as a temporary measure is harmless, I'll do it right now. No need to bug @kwilcox! Thanks. |
@emiliom, do you crawl a list of thredds catalogs periodically (e.g. at least once per day), extracting the ISO metadata using the ncISO services you find on THREDDS and dropping them into your WAF? If the answer is yes, then yes, just add that OSU thredds catalog to the list of catalogs you already scan, and we can tell NGDC to stop accessing that data via the OPeNDAP link (and processing with their old standalong ncISO) |
No, I have a WAF with manually placed iso xml's. Doing what you describe is what I intend to do next month. |
So for now, I think adding the OSU model to the Axiom WAF is fine. Time range searches will only find one dataset: the one from the Axiom WAF. |
@ocefpaf: The NANOOS SOS is working now! But since I have never issued a bounding-box filtered request with pyoos IoosSweSos, I can't get that to work yet (and don't know for sure that it's implemented correctly). Independent of pyoos, I was able to successfully issue a POST request with a bounding box filter for the OOI endurance array box (and the temporal and variable name filters in your notebook), so that's a good sign. |
hey folks - This is the main thread where you all have started using my old username. I changed it from @jenniferbosch to @jbosch-noaa at the request of Derrick. This is so we have some consistency in IOOS github presence. :) Happy New Year! |
Thanks for letting us know @jbosch-noaa! (I just invited you to the ioos org BTW.) |
@rsignell-usgs (et al?)
FYI, the OSU ROMS model record is not showing up yet. I reran @ocefpaf's CSW query, and also looked manually on the NGDC GeoPortal browse page under AOOS and CeNCOOS (the "Axiom WAF"?), but didn't find it. It won't make it to the OOI notebook, but no worries. We'll address this on the NANOOS end over the next couple of weeks. Thanks. |
Strange, as it's showing up here: |
The |
@kwilcox , crap, I didn't realize that. @robragsdale, I think it's too late now to show up in time for the OOI presentation, but could you make this happen anyway? |
@rsignell-usgs I am updating the NANOOS WAF. |
@robragsdale, there's some confusion here. The WAF @rsignell-usgs is referring to is apparently not registered. @kwilcox and @rsignell-usgs set it up only as a temporary measure to store a NANOOS model ncISO ISO record, so it'd make it into the NGDC GeoPortal in time for the OOI workshop that starts tomorrow; to overcome a limitation with the older version of ncISO @amilan17 is using. I've added a manually extracted version of the ISO record in question to the existing, registered NANOOS WAF just now (it's here). If you updated that WAF right after I uploaded the iso file to it, hopefully it got pulled in. FYI, this is a temporary measure, too. Thanks all! No worries if we can't manage to make it show up by tomorrow. I suspect @kbailey-noaa needs it sooner than tomorrow anyway, b/c she was going to take snapshots from the notebook. |
Thanks for the clarification @emiliom. The registry harvests overnight, so it will not be discoverable in the NCEI (formerly NGDC) GeoPortal until tomorrow morning. |
I just tried a search on geoportal, and it's not there yet. 😢 Also, @emiliom or @crisien, I noticed that the ISO metadata for this dataset Is this aggregation updating correctly? |
Hi Rich, The end date is now Dec 31, 2015. The reason it ends on Dec 31 is that Regards, -Craig On 1/5/2016 3:02 AM, Rich Signell wrote:
|
Ditto, just now. Thanks for testing, @rsignell-usgs @crisien, thanks for your response on the TDS ending date issue. I hadn't realized that the new model had not made it over to TDS. Darn. Lots to catch up on next week. |
I re-synced geoportal - it should be there now.. Anna On Tue, Jan 5, 2016 at 10:39 AM, Emilio Mayorga notifications@github.com
|
FYI, the NANOOS WAF OSU ROMS record has not showed up on geoportal. Let's give up on providing a temporary access point for this record. However, I do want to make sure there isn't a broader problem with harvesting from that NANOOS WAF; the 4 iso xml's that have been there for over a year are still on geoportal. The only unusual thing about the new record is that it's potentially a duplicate of the primary OSU ROMS record (from THREDDS), at least in terms of the iso document id. If there is a real, broader problem with the WAF, I can create a new and more specific issue under ioos/registry to follow up. Otherwise I think we're done with this topic on this sprawling issue! |
@emiliom if you have some spare time can you take a look the notebook [1] and make a few comments? Specially regarding to what we should've found but didn't.
[1] https://github.com/ocefpaf/sscsw/blob/master/IOOS_data_demo.ipynb
The text was updated successfully, but these errors were encountered: