Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow account creation requests to be approved in Slack #13

Open
jvperrin opened this issue Aug 16, 2017 · 5 comments
Open

Allow account creation requests to be approved in Slack #13

jvperrin opened this issue Aug 16, 2017 · 5 comments

Comments

@jvperrin
Copy link
Member

Account creation requires users to be an OP on IRC, but this means that users from Slack cannot approve accounts or do anything that requires OP permissions.

It would be nice (but probably impractical) to have account creation done with action buttons. Then for permissions, have either a list of authorized users that can approve accounts, a separate private channel where accounts are approved (meh), or something that figures out which users are privileged (either in NickServ or in ocfstaff/ocfroot) and allows those users to approve requests.

@chriskuehl
Copy link
Member

My original idea was to just have the bridge tag people who are trusted based on their email (for example, add "($username)" to the end of their name field?). Then create can verify if someone is staff by checking that (a) they're from the bridge (verify via ip address?), and (b) their username is staff.

Action buttons also sound fine, but more complicated.

@jvperrin
Copy link
Member Author

Via IP address might be a bit tougher, since it's running on Marathon, but that would be doable. I was thinking just add NickServ to IRC user bots (#6), and then grab their username from their nick (<user>-slack), but that's not the safest since anyone can set their username to anything on Slack, so they could impersonate someone.

The action buttons are honestly an extra thing that will probably never happen since it's unnecessarily complicated when regular create commands could just be used. It is nice to have some large red and green buttons for rejecting and approving an account though, just looks fancier.

@chriskuehl
Copy link
Member

NickServ sounds like a good solution.

@chriskuehl
Copy link
Member

chriskuehl commented Aug 17, 2017

IP auth is also possible if we made flood a Marathon agent (in a non-standard pool) and pinned the slack bridge to it, but meh.

@kkuehlz
Copy link
Member

kkuehlz commented Oct 2, 2017

Now that @redplanks has implemented nickserv auth for slack bots in #31, one possibility is to have ops respective slack bots in a privileged nick group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants