This repository has been archived by the owner on Aug 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
@oclif/config should be a production dependency #59
Comments
ersinakinci
changed the title
Why is @oclif/plugin not a production dependency?
Why is @oclif/config not a production dependency?
Apr 26, 2019
ersinakinci
changed the title
Why is @oclif/config not a production dependency?
@oclif/config should be a production dependency
Apr 26, 2019
Just came across this with |
This was referenced Jun 18, 2019
Tip for all package maintainers: try installing your package with |
Added as peerDependency 903785b |
@RasPhilCo Just curious why it's a peerDependency and not a dependency. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In https://github.com/oclif/command/blob/master/src/command.ts#L51,
@oclif/config
is used as part of therun
method. So why is it that inpackage.json
, it's not listed as a production dependency? Is it because it's listed as such in the main oclif package here?The current arrangement breaks monorepo projects whose dependencies are managed by pnpm because of the way each monorepo dependency's dependencies are isolated from each other. If we could move the
@oclif/config
dependency out ofdevDependencies
and intodependencies
, that would be 🔥 🔥 🔥 . It's also more correct since@oclif/config
is being used at runtime.PR: #60
CC: @zkochan
The text was updated successfully, but these errors were encountered: